pomdtr / vscode-markdown-kroki

Adds Kroki support to VS Code's builtin markdown preview
https://marketplace.visualstudio.com/items?itemName=pomdtr.markdown-kroki
MIT License
21 stars 7 forks source link

Couldn't make it work from a markdown code block. #9

Closed mpenna closed 5 months ago

mpenna commented 11 months ago

I'm testing out this extension along with a Dockerized instance of Kroki. I have setup two containers on the same bridged network, thus they can see each other:

Despite having configured this extension's settings with the URL of the Kroki container, along with a "kroki-" prefix, while working inside VSCode and attached to the workspace container, nothing happens when I for instance add a "kroki-blockdialog" code block to a markdown file:

blockdiag {
  blockdiag -> generates -> "block-diagrams";
  blockdiag -> is -> "very easy!";

  blockdiag [color = "greenyellow"];
  "block-diagrams" [color = "pink"];
  "very easy!" [color = "orange"];
}

Issuing a simple GET request against the Kroki container from the workspace container's terminal (via curl) works without issues.

Any ideas what could be the issue here? Is it possible to debug the extension to see if something is breaking?

albbino commented 11 months ago

Same Problem to ne.

acmnu commented 6 months ago

@mpenna As far as I know, you shouldn't say "blockdiag" again when we are talking about Markdown:

That is original structurizr format

blockdiag {
  blockdiag -> generates -> "block-diagrams";
  blockdiag -> is -> "very easy!";

  blockdiag [color = "greenyellow"];
  "block-diagrams" [color = "pink"];
  "very easy!" [color = "orange"];
}

And that is the format of embedded kroki structurizr:

```kroki-blockdiag
{
  blockdiag -> generates -> "block-diagrams";
  blockdiag -> is -> "very easy!";

  blockdiag [color = "greenyellow"];
  "block-diagrams" [color = "pink"];
  "very easy!" [color = "orange"];
}
```
pomdtr commented 5 months ago

@mpenna @albbino did you test the suggestion ? Closing it for now, I'll reopen if the issue is not resolved