search

pomerol-ed / pomerol2triqs

Quick and dirty TRIQS wrapper around the Pomerol exact diagonalization library
GNU General Public License v3.0
9 stars 7 forks source link

Update to TRIQS 3 and Python 3 #14

Closed Wentzell closed 4 years ago

Wentzell commented 4 years ago

This PR will update pomerol2triqs to Python 3 and the latest TRIQS release (3.0.0).

krivenko commented 4 years ago

Thank you so much, Nils!

I must try to build and run this on my machine before I merge.

The only question I have right now is whether it is necessary to switch to the Bionic image on Travis? What is the oldest Ubuntu version officially supported by TRIQS 3.0?

krivenko commented 4 years ago

This issue is apparently making a return in TRIQS 3.0 (see Travis clang compilation log)...

Wentzell commented 4 years ago

Thank you so much, Nils!

I must try to build and run this on my machine before I merge.

The only question I have right now is whether it is necessary to switch to the Bionic image on Travis? What is the oldest Ubuntu version officially supported by TRIQS 3.0?

We only officially support Ubuntu 18.04 and 20.04. That is also why I changed the image in travis.

Wentzell commented 4 years ago

This issue is apparently making a return in TRIQS 3.0 (see Travis clang compilation log)...

Yeah it seems to be the same problem. I can replay your workaround also on the cpp2py master branch.

Wentzell commented 4 years ago

This issue is apparently making a return in TRIQS 3.0 (see Travis clang compilation log)...

Yeah it seems to be the same problem. I can replay your workaround also on the cpp2py master branch.

This should now be addressed in https://github.com/TRIQS/cpp2py/commit/98bd1b2d5e91d7ea4936f4d33c199a83c79671d1

krivenko commented 4 years ago

Thank you once again, Nils! Everything looks fine now.