pomm-project / pomm-bundle

Pomm2 bundle for Symfony
81 stars 31 forks source link

The PommProject\SymfonyBridge\PropertyInfo\Extractor\PommExtractor class is deprecated #112

Closed maximechagnolleau closed 3 years ago

maximechagnolleau commented 3 years ago

Hi,

I use pomm-bundle in a Symfony 4.4 project. Since the 2.3 version of POMM, I have the following notice:

User Deprecated: The PommProject\SymfonyBridge\PropertyInfo\Extractor\PommExtractor class is deprecated since version 2.3 and will be removed in 3.0. Use the PommProject\SymfonyBridge\PropertyInfo\Extractor\TypeExtractor class instead.

So I have upgraded pomm-bundle to version 3.0, but I still have this notice message.

Could you please give me an explanation ? Have I missed something and is there a way to avoid these notices ?

Thank you

rdavaillaud commented 3 years ago

Well, it seems that this class is still defined as a service in https://github.com/pomm-project/pomm-bundle/blob/3.0.0/sources/lib/Resources/config/services/pomm.yml#L39

@stood I think we just have to remove that in the bundle.

maximechagnolleau commented 3 years ago

That's what I think. This class was supposed to be removed in v3.0

Doud63 commented 3 years ago

But symfony bridge was already in version 3, and deprecation is not removed? This error is blocking

rdavaillaud commented 3 years ago

How is it blocking? Isn't it just a deprecation notice?

The class itself is not used anymore, just declared in the service container, with a deprecation notice and a class_alias https://github.com/pomm-project/pomm-symfony-bridge/blob/3.0.0/sources/lib/PropertyInfo/Extractor/PommExtractor.php

maximechagnolleau commented 3 years ago

That's not blocking. But deprecation messages still appears without any reason.

Doud63 commented 3 years ago

Sorry for the time of my answer. I work in PHP 8, and i have this error in test environment Error : Class "PommProject\SymfonyBridge\PropertyInfo\Extractor\PommExtractor" not found

Thanks for your Pull Request, rdavaillaud