search

pomm-project / pomm-bundle

Pomm2 bundle for Symfony
81 stars 31 forks source link

Rename connection to session in ParamConverter #66

Closed Nedeas closed 7 years ago

Nedeas commented 7 years ago

There are a typo in ParamConverter. In options, it's connection which is tested but it's session which is to use.

sanpii commented 7 years ago

Can you add a non-regression test?

Nedeas commented 7 years ago

I work on.

Nedeas commented 7 years ago

Test added !

chanmix51 commented 7 years ago

awesome :+1:

sanpii commented 7 years ago

I try to merge your PR but your branch have a trange history: 2017-04-12-151608_1676x993_scrot

Can you flaten its?

Nedeas commented 7 years ago

@sanpii Done

sanpii commented 7 years ago

Nice work, thank you.