search

pomm-project / pomm-bundle

Pomm2 bundle for Symfony
81 stars 31 forks source link

[WIP] Add support sf4 #90

Closed stood closed 6 years ago

mvrhov commented 6 years ago

My PR opened 8 moths ago should be merged first, and then this one rebased on top of it.

EvKoh commented 6 years ago

+1 for this PR !!!

stood commented 6 years ago

@chanmix51 can you tag CLI plz for support 4.0 ?

sanpii commented 6 years ago

Ok, I think I have understood the problem with php5.4 and symfony 3/4 build.

PHP 5.4 force symfony to keep in 2.8 version: https://travis-ci.org/pomm-project/pomm-bundle/jobs/323213244#L612

We need a better way to dertermine if we should launch @upper2lts tagged tests.

current_version=$(composer show --format=json | jq '.installed[] | select(.name == "symfony/symfony") | .version' | sed 's/^"v\([^"]*\)"/\1/')
sf2 = $(dpkg --compare-versions "$current_version" "lt" "3"; echo $?)
test $sf2 == 0 && ./bin/behat --tags '~@upper2lts' ||./bin/behat