pomm-project / pomm-symfony-bridge

Pomm2 shared elements for profiler between Silex and Symfony.
8 stars 17 forks source link

[WIP] Create flexible entity #17

Closed stood closed 6 years ago

stood commented 9 years ago

ToDo list:

chanmix51 commented 9 years ago

If I may dare a comment about the coding conventions, Pomm uses underscore format for attributes and variables. AFAIK, the bundle follows the same conventions. I let @sanpii chose what to do with that.

stood commented 9 years ago

Oh yes I'm sorry :) I will correct this in the Test & Review task :)

sanpii commented 8 years ago

Can you add some fuctionnal tests to pomm bundle? This will probably accelerate my review :yum:

sanpii commented 7 years ago

I tried to testing this PR, but I have some difficults with the form component.

I think, it miss some glue for the bundle (at least a form type extension) and I had an error with FlexibleEntityType constructor parameters 😢