search

pomonahci / EyeWrite

An extension of collaborative document editor Firepad that supports gaze sharing
2 stars 0 forks source link

Un-undoable strokes in eyedraw #15

Closed andyqhan closed 2 years ago

andyqhan commented 2 years ago

We've had this bug for a while, and it's not as bad as it was. However, it still exists. One way to reproduce it:

  1. Open eyedraw on two computers.
  2. Draw at the same exact time on both computers.
  3. Repeat 2 until you notice that one of the computers' stroke does not stop when you lift the mouse button. That is, the stroke keeps drawing as if you were click-and-dragging, but you're just dragging.

Then that last stroke on the offending computer is un-undoable.

(The bug persists after closing #13.)

andyqhan commented 2 years ago

Additionally, it seems like the combination of the ability to undo the clear-canvas and the ability to redo that undo causes sync problems. I can't pin down a consistent reproduction. Maybe because clear-canvas allows a user to modify other users' strokes. Do we really need redo and clear canvas? (Do we even need undo?)

alexpapster commented 2 years ago

As long as erase stroke is available, I think we can remove undo/redo and be done with this bug.

On Tue, Feb 8, 2022, 5:11 PM Andy Han @.***> wrote:

Additionally, it seems like the combination of the ability to undo the clear-canvas and the ability to redo that undo causes sync problems. I can't pin down a consistent reproduction. Maybe because clear-canvas allows a user to modify other users' strokes. Do we really need redo and clear canvas? (Do we even need undo?)

— Reply to this email directly, view it on GitHub https://github.com/pomonahci/EyeWrite/issues/15#issuecomment-1033226256, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQ2RJBFKVH3WK37T2D6CVDU2G5NZANCNFSM5N4BY3MQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

andyqhan commented 2 years ago

Closed with 3f60f87a266bb4b12bcc8871076d6408af2424d5