pompobit / ScanGO

Scan nearby pokemons and get notified with push notifications
51 stars 13 forks source link

Source code #12

Open mjurinic opened 8 years ago

mjurinic commented 8 years ago

Am I blind or there's no source code in this repo? In every release you're linking "source code" downloads and it's just images and .xmls

pompobit commented 8 years ago

you are not blind, source code is not actually released ;) When I do a release the src.zip is automatically added, but contains just images that I use to build the main page of github. I included also xmls to translate the app but are outdated

mjurinic commented 8 years ago

Is there any reason behind that? :D

vuldin commented 8 years ago

I'd like to request source code as well. My argument or reason is security: it is trivial for Niantic to determine whether or not this package is installed on a device. If this app continues to grow in popularity, then they will surely starting doing this.

Maybe there is another alternative to releasing the full source code, one that would allow users of this app to build their own package with a unique package name. This would be an adequate alternative at least for myself... I'm not interested in changing anything else about the app other than the package name.

pompobit commented 8 years ago

It's very unlikely that Niantic will ever ban someone becuase it has another installed app, there are several reasons because that and the main one is that an account is not bound with a device or viceversa.

Anyway I prefer to not release source code because it would mean that clones would pop everywhere, like what happened with PokeScanner, they had to close source code at certain point when cloend apps appeared on markets without even giving credits. I'm spending a lot of spare time (it exist?) to mantain this app and the few dollars I make from Ads (you see that I use only the non-invasive ones) are not nearly enough proportionally to time spent. I don't think that let everyone to make his own version free would be an incentive to improve ScanGO further.

Anyway if Niantic will build a check to see other installed apps, I'll think something about it :)

Googulator commented 7 years ago

Is it even legal to host closed-source binaries on GitHub?