Can't update Nearby Share to Quick Share

ponces / treble_aosp

Script and patches for building TrebleDroid AOSP

Other

179 stars 46 forks source link

Can't update Nearby Share to Quick Share #90

Closed szmarczak closed 4 months ago

szmarczak commented 4 months ago

Acknowledgements

[X] I have chosen an appropriate title.
[X] All requested information has been provided properly.
[X] This is not a feature request.
[X] This issue is not a duplicate of an existing issue.
[X] The issue is solely related to this GSI.
[X] This issue occurs with the latest available build.
[X] I am not running a custom vendor on my device.
[X] This issue is not kernel related.
[X] This issue is not related to Magisk/KernelSU/APatch.

Info

Device: Samsung Galaxy A40
GSI version: AOSP 14.0 v2024.05.09
Vendor version: latest

Expected Behavior

Clicking Update should enable Quick Share.

Current Behavior

Opens Galaxy Store (which may be not installed). Installing Quick Share from the Galaxy Store doesn't work (Quick Share crashes).

Possible Solution

No response

Steps to Reproduce

Open Nearby Share.
Click Update.
Nothing happens.

Logs

No response

Additional context

No response

TechySkills commented 4 months ago

Hmmm that is sus, because i use a february version and didnt even need to click update it just auto updated... ???

szmarczak commented 4 months ago

@TechySkills is your phone Samsung as well?

TechySkills commented 4 months ago

No brother Regards TechySkills

On Sat, May 11, 2024 at 7:07 PM Szymon Marczak @.***> wrote:

@TechySkills https://github.com/TechySkills is your phone Samsung as well?

— Reply to this email directly, view it on GitHub https://github.com/ponces/treble_aosp/issues/90#issuecomment-2105819004, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATS23J7RIXFAAW4KHDDDDPTZBYQ2PAVCNFSM6AAAAABHR5VGFWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVHAYTSMBQGQ . You are receiving this because you were mentioned.Message ID: @.***>

ponces commented 4 months ago

Nearby Share is provided by GMS, it's not a dedicated app. So most likely you are talking about another one. Anyway, this is not related with my GSI.

szmarczak commented 4 months ago

Isn't it possible to ship GSI with Quick Share updated already?

szmarczak commented 4 months ago

From Wikipedia:

In 2024, Google integrated Nearby Share into Quick Share and adopted Samsung's Quick Share to form one unified app,[1] distributing Quick Share to non-Galaxy Android devices through Google Play Services.

So indeed it looks like GMS detects it's a Samsung and tries to open the Samsung version instead...

szmarczak commented 4 months ago

I tried https://xdaforums.com/t/solution-nearby-share-not-updating-to-quick-share.4670567/ and it didn't work. I also tried editing the manufacturer, brand (left the fingerprint unchanged) in /vendor and /vendor/odm but that didn't help too.