Is there a maximum size in bytes for an input when creating a GGPOSession?

pond3r / ggpo

Good Game, Peace Out Rollback Network SDK

MIT License

3.11k stars 360 forks source link

Is there a maximum size in bytes for an input when creating a GGPOSession? #54

Closed Eoin-ONeill-Yokai closed 4 years ago

Eoin-ONeill-Yokai commented 4 years ago

So I've been testing GGPO on Linux, which I know isn't a supported plaform yet, and I've run into a small problem. I've noticed that GGPO crashes when the input size is anything larger than 18 bytes. Is 18 bytes the maximum input size that GGPO supports? Or is this simply a bug? I'm using a branch based on PR #52 .

Shugyousha commented 4 years ago

It looks like 18 bytes is the preconfigured max: https://github.com/pond3r/ggpo/blob/master/src/lib/ggpo/game_input.h#L26

I assume that can be adjusted freely (as long as you make sure to heed this comment: https://github.com/pond3r/ggpo/blob/master/src/lib/ggpo/game_input.h#L14).

pond3r commented 4 years ago

Yes, you should be fine, though I've never tested it with inputs that large.

Eoin-ONeill-Yokai commented 4 years ago

Ok that's good to know.

I'm going to go ahead and close this issue then since it seems to be addressed. Thanks for taking the time to respond!