search

ponday-dev / rollup-plugin-lit-sass

3 stars 4 forks source link

Possibly move to dart-sass #3

Open kilmc opened 3 years ago

kilmc commented 3 years ago

I was hoping to use this plugin for a project I'm working on but I'm using some newer sass features like @use which are not supported by libsass or in turn node-sass as both projects have been slow to adopt new sass features. The sass team wrote a blog post in October of last year saying libsass and other sass implementations that were built on top of it were deprecated. Their recommendation moving forward is to use dart-sass.

Here's the blog post but the TL;DR is

We no longer recommend LibSass for new Sass projects. Use Dart Sass instead.

I'm happy to make a PR for this but wasn't sure what way you like folks contributing to your project so I thought I'd post an issue first to see.

Thanks

ViRuSTriNiTy commented 3 years ago

Hmm, no one seems to answer but I need this functionality too. Can you please share your solution in a PR?

ViRuSTriNiTy commented 3 years ago

I created a copy of this module to test how the move could be done. It is really just replacing

import sass from 'node-sass';

by

import sass from 'sass';

as the options interface is compatible. Now only the author of this package needs to answer.

ViRuSTriNiTy commented 3 years ago

As I needed to make some progress here I took the task of resolving this issue.

Created a fork https://github.com/ViRuSTriNiTy/rollup-plugin-lit-sass from this repo, applied the commits linked above, created a PR from these commits and published the repo as a new package https://www.npmjs.com/package/@j1shin/rollup-plugin-lit-sass to the public npm registry.

Now it would be nice to get the PR merged so that my fork is not necessary anymore.