Error with `matches` - Githubissues

tatianacv commented 1 year ago

Fixes # .

Commits

[ ] I slowed down and took a deep breadth before committing. Otherwise, I will start a pristine branch and reissue this pull request.
[ ] Before committing my changes, I checked my working directory carefully. I only staged the changes I wanted and ensured it was of the utmost quality.
[ ] I used git diff and git status to check my work carefully before committing.
[ ] I completely understand what I am committing and why.
[ ] I completely understand why things are the way they are.
[ ] The change I am proposing makes complete sense to me.
[ ] For the most part, the changes in this pull request correspond to the problem or task I am solving or performing. In other words, only the changes that are supposed to be there are the ones included in this pull request.

[ ] If this is a bug fix, I was able to reproduce the problem locally before I made any changes (can use git stash to temporarily reset the working directory).
[ ] When I made (or put back) my changes, the problem I reproduced above was fixed.

[ ] The changes I am proposing meet the expectations I have described above.
[ ] I have performed a self-review of my code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation if applicable.
[ ] I have added tests that prove my fix is effective or that my feature works if applicable.
[ ] New and existing unit tests pass locally with my changes.

khatchad commented 1 year ago

Why are there so many commits here? I should just see one or two commits if you started from upstream/master.

khatchad commented 1 year ago

Please start a new one from upstream/master.