search

ponder-lab / Hybridize-Functions-Refactoring

Refactorings for optimizing imperative TensorFlow clients for greater efficiency.
Eclipse Public License 2.0
0 stars 0 forks source link

Missing dataset elements as tensors #306

Closed khatchad closed 10 months ago

khatchad commented 10 months ago

Parameters images and labels should both be tensors here:

https://github.com/ponder-lab/samples/blob/39f7644391e664244b45c90868c804abad923eb3/tensorflow_eager_execution/tensorflow_eager_execution.py#L24-L32

Instead, as of c5f3fc3735a82c93f37d143c47d88cdc907b0be9, I am getting the following:

subject function module relative path parameters tensor parameter hybrid side-effects recursive autograph experimental_autograph_options experimental_follow_type_hints experimental_implements func input_signature jit_compile reduce_retracing refactoring passing precondition status
samples test_step tensorflow_eager_execution tensorflow_eager_execution/tensorflow_eager_execution.py 5 FALSE TRUE FALSE   FALSE FALSE FALSE FALSE FALSE FALSE FALSE FALSE OPTIMIZE_HYBRID_FUNCTION P2 0
samples train_step tensorflow_eager_execution tensorflow_eager_execution/tensorflow_eager_execution.py 5 FALSE TRUE FALSE   FALSE FALSE FALSE FALSE FALSE FALSE FALSE FALSE OPTIMIZE_HYBRID_FUNCTION P2 0

Similarly for test_step().

They're coming from here:

https://github.com/ponder-lab/samples/blob/39f7644391e664244b45c90868c804abad923eb3/tensorflow_eager_execution/tensorflow_eager_execution.py#L88-L89

Seems related to #305.

khatchad commented 10 months ago

Following the fix for #305, I am now seeing:

subject function module relative path parameters tensor parameter primitive parameter hybrid side-effects recursive autograph experimental_autograph_options experimental_follow_type_hints experimental_implements func input_signature jit_compile reduce_retracing refactoring passing precondition status
samples train_step tensorflow_eager_execution tensorflow_eager_execution/tensorflow_eager_execution.py 5 TRUE FALSE TRUE FALSE FALSE FALSE FALSE FALSE FALSE FALSE FALSE FALSE FALSE OPTIMIZE_HYBRID_FUNCTION   3
samples test_step tensorflow_eager_execution tensorflow_eager_execution/tensorflow_eager_execution.py 5 TRUE FALSE TRUE FALSE FALSE FALSE FALSE FALSE FALSE FALSE FALSE FALSE FALSE OPTIMIZE_HYBRID_FUNCTION   3