search

ponder-lab / Imperative-DL-Study-Web-App

0 stars 0 forks source link

Make migration command the first line in procfile #164

Closed ZhongweiL closed 2 years ago

ZhongweiL commented 2 years ago

Moving the migration command to the first line because the original change didn't work, following up on #159

khatchad commented 2 years ago

Again, no description. Why do we need this change?

ZhongweiL commented 2 years ago

@khatchad Done.

khatchad commented 2 years ago

I don't think it's going to matter. Also, is this supposed to make the tests pass?

ZhongweiL commented 2 years ago

If the database gets updated successfully, the test test_same_name should pass because the current model is allowing duplicate names. But test_same_user should still fail because we reverted the changes to the user field.

khatchad commented 2 years ago

That change didn't work and wasn't thoroughly tested so we need to get it to pass.

ZhongweiL commented 2 years ago

I found a fix for that https://github.com/ponder-lab/Imperative-DL-Study-Web-App/issues/147#issuecomment-993930465

khatchad commented 2 years ago

Are you sure that migraine are your problem?

khatchad commented 2 years ago

You can't make something unique when the task name says add a foreign key. And a comment isn't a fix. Code is a fix.

khatchad commented 2 years ago

I'll merge this but I doubt it will make a difference.