search

ponder-lab / Imperative-DL-Study-Web-App

0 stars 0 forks source link

Is func fix should be true or false #31

Closed khatchad closed 3 years ago

khatchad commented 3 years ago

https://fathomless-inlet-57767.herokuapp.com/ponder/bug_fixes/

b'\x00' -> false b'\x01' -> true

mZneit commented 3 years ago

@tatianacv - in the database, is it possible to change the type of the column "is_func_fix" in the bug_fixes table from "bit" to "tinyint"? I'm getting a "command denied to user" error. Here's the SQL command: ALTER TABLE bug_fixes MODIFY COLUMN is_func_fix TINYINT

khatchad commented 3 years ago

I have fixed this in our production database. This happened because of a schema mistake there and that DB was imported here. @tatianacv will fix in the dev database.

khatchad commented 3 years ago

For the boolean columns, how about using ticks? For example, heavy_check_mark could be for true (Unicode hex code 2714) and heavy_multiplication_x could be for false (2716)?

tatianacv commented 3 years ago

I have fixed this in our production database. This happened because of a schema mistake there and that DB was imported here. @tatianacv will fix in the dev database.

I have updated in the dev database.

mZneit commented 3 years ago

Thank you for fixing the db.

khatchad commented 3 years ago

Should we change this one to Booleanfield?

tatianacv commented 3 years ago

Should we change this one to Booleanfield?

Tiny int(1) is boolean, we saw that when we changed the from the production database.

tatianacv commented 3 years ago

I think this was temporarily assigned to me so I could fix in dev, this should be assigned back to Manal?

mZneit commented 3 years ago

There is a way in django to keep the integer value stored in the database and display a human-readable value such as ✘ or ✔. I tried this mapping of values and it worked while keeping the IntegerField type. I didn't commit any changes but if ok will update the code.

khatchad commented 3 years ago

@mZneit will try the Booleanfield.