search

ponder-lab / Imperative-DL-Study-Web-App

0 stars 0 forks source link

Should this be class Commit (singular)? #46

Closed khatchad closed 3 years ago

khatchad commented 3 years ago

https://github.com/ponder-lab/Imperative-DL-Study-Web-App/blob/47c55f03ce4ec99224cbc4e166c426b34e098233/ponder/models.py#L89

Does not an instance of a Commits represent a single commit, thus Commit?

khatchad commented 3 years ago

Likewise for other classes?

tatianacv commented 3 years ago

This represents the table, so its commits table because its the conglomerate of all the commits.

khatchad commented 3 years ago

But, it extends Model. The way it reads now, Commits is-a Model. The multiplicity doesn't match. Either commits are models or a commit is a model.

khatchad commented 3 years ago

In other words, Commit represents a commit, i.e., a single row in the commits table. In contrast, Commit.objects is all of the commits.

See this example. Here, it's class Person(Model) instead of class People(Model). Make sense?

tatianacv commented 3 years ago

Created a pull request for this

khatchad commented 3 years ago

Great, what is the PR?

khatchad commented 3 years ago

This seems to be addressed as part of #55.