search

ponder-lab / Imperative-DL-Study-Web-App

0 stars 0 forks source link

Categorization model and form updates #54

Closed mZneit closed 3 years ago

mZneit commented 3 years ago

issue #53 Changed is_func_fix and should_discuss columns to booleans in both models: Categorizations and BugFixes. Mapped the integer values of columns in Categorizations model to text. Mapping integer values to their corresponding text values requires relational fields. That's why ForeignKeys were introduced.

khatchad commented 3 years ago

@mZneit Can you briefly describe what this PR is doing?

khatchad commented 3 years ago

The new changes still give the option to add new categories when run locally... as well as the dropdown.

That sounds pretty good to me!

mZneit commented 3 years ago

Should I merge this PR?

khatchad commented 3 years ago

Should I merge this PR?

I think we should wait for @tatianacv's review.

khatchad commented 3 years ago

So, what are the consequences now of this merged PR? Is it possible to add new categories?

mZneit commented 3 years ago

The goal of this PR was to change the integer columns of problem categories, fixes, causes... to text. There was a problem because the Categorization model was referenced in the Categorization form. But any issue the form had with adding new categories is still not fixed.

tatianacv commented 3 years ago

There were no issues previously with the form.

tatianacv commented 3 years ago

We are just adding functionality now.