search

ponder-lab / Imperative-DL-Study-Web-App

0 stars 0 forks source link

New categorization form entry doesn't work #58

Closed khatchad closed 3 years ago

khatchad commented 3 years ago

I tried to enter a categorization for 053b4b28b6f25f69d6f4d7819106392999f52dc3. To do that, I used https://fathomless-inlet-57767.herokuapp.com/ponder/categorizations/add%3Fcommit=053b4b28b6f25f69d6f4d7819106392999f52dc3. The form submission seemed successful (I didn't see any error message, but there really wasn't any indication that anything actually happened). The categorization was simply setting "is bug fix" to FALSE. However, when I went to https://fathomless-inlet-57767.herokuapp.com/ponder/categorizations?user=11, I don't see this new categorization.

I should note that https://fathomless-inlet-57767.herokuapp.com/ponder/categorizations?user=11 alrfeady includes a categorization for 053b4b28b6f25f69d6f4d7819106392999f52dc3:

  1. Is this not working because there's already a categorization there? If so, there should be some kind of error message regarding this?
  2. Should users be allowed to categorize a commit multiple times?
tatianacv commented 3 years ago

cannot reproduce

tatianacv commented 3 years ago

I tried to enter a categorization for 053b4b28b6f25f69d6f4d7819106392999f52dc3. To do that, I used https://fathomless-inlet-57767.herokuapp.com/ponder/categorizations/add%3Fcommit=053b4b28b6f25f69d6f4d7819106392999f52dc3. The form submission seemed successful (I didn't see any error message, but there really wasn't any indication that anything actually happened). The categorization was simply setting "is bug fix" to FALSE. However, when I went to https://fathomless-inlet-57767.herokuapp.com/ponder/categorizations?user=11, I don't see this new categorization.

I should note that https://fathomless-inlet-57767.herokuapp.com/ponder/categorizations?user=11 alrfeady includes a categorization for 053b4b28b6f25f69d6f4d7819106392999f52dc3:

1. Is this not working because there's already a categorization there? If so, there should be some kind of error message regarding this?

2. Should users be allowed to categorize a commit multiple times?

You can categorize the same commit twice or how many time you want. There might be multiple bugs in the same commit.