search

ponder-lab / Imperative-DL-Study-Web-App

0 stars 0 forks source link

Add the ability to create, update, and delete bug fixes #71

Open khatchad opened 3 years ago

khatchad commented 3 years ago

Note that this should be done only by users having a particular role per #17.

mZneit commented 3 years ago

This is the commit. https://github.com/ponder-lab/Imperative-DL-Study-Web-App/commit/28a880a5292526e2c03ce6c3e34332b8d088f886

The form creates new bugfixes, updates, and deletes them. I added a search by round filter but not activated yet. I'm not sure if it's needed.

khatchad commented 3 years ago

I think the round is useful but it should be a dropdown prepopulated with the rounds that relate to the bug fix table. Thanks, Manal!

mZneit commented 3 years ago

ok will do this.

khatchad commented 3 years ago

I think this needs more discussion, @mZneit. Particularly, bug fixes should be created from categorizations. Please set up a meeting next week to discuss the workflow further.

khatchad commented 3 years ago

The update makes sense though.

khatchad commented 3 years ago

But you can see that the creation is not quite right because the SHA is blank. This will need to be more like how categorizations are created from commits, e.g., https://fathomless-inlet-57767.herokuapp.com/ponder/categorizations/add?commit=00a33f7e060caa6616c15003bdac95b7926b76ae

khatchad commented 3 years ago

Also, the routes are not quite right. See the article I posted last week.

khatchad commented 3 years ago

Actually, adding and editing bug fixes should only be done by reconcilers. Thus, this is really blocked on #17. I would move this out of the main branch and put it on a feature branch.

mZneit commented 3 years ago

I think this needs more discussion, @mZneit. Particularly, bug fixes should be created from categorizations. Please set up a meeting next week to discuss the workflow further.

Ok. I will.

mZneit commented 3 years ago

But you can see that the creation is not quite right because the SHA is blank. This will need to be more like how categorizations are created from commits, e.g., https://fathomless-inlet-57767.herokuapp.com/ponder/categorizations/add?commit=00a33f7e060caa6616c15003bdac95b7926b76ae

Yes, but the form doesn't submit if it's blank, it's a required field. But I agree that it should come from commits.

khatchad commented 3 years ago

Thanks, @mZneit. I think we will need #17 before we can really have this one.

mZneit commented 3 years ago

I will not work on it at this moment, but do we need to move it to another branch?

khatchad commented 3 years ago

I believe so, because we don't want categorizers accidently modifying existing bug fixes. The idea of #17 is that only reconcilers will be able to do that. Since there is only one "role" now, everyone is categorizer.