Add more bug fix details to the bug fix details view

khatchad commented 3 years ago

Related to #68. On top of the categorizations in the bug fix details view, we could have the actual details of the bug fix in addition to the categorizations for that bug fix. What I have in mind is something like this (field/value row doesn't apply and other columns are not present for brevity):

Bug Fix 1

Field	Value
SHA	00a33f7e060caa6616c15003bdac95b7926b76ae
Is func fix	✘
Problem category	—

Categorizations

ID	Sha	Is func fix	Func fix comment	Problem category	Category comment	Problem cause	Cause comment	Problem symptom	Symptom comment	Problem fix	Fix comment	Categorizer	Should discuss	Bug fix
1	00a33f7e060caa6616c15003bdac95b7926b76ae	✘	—	—	—	—	—	—	—	—	—	tcastrovelez	—	BugFix object (1)

khatchad commented 3 years ago

Please push.

khatchad commented 3 years ago

field/value row doesn't apply and other columns are not present for brevity)

khatchad commented 3 years ago

Also missing:

Bug Fix 1

mZneit commented 3 years ago

field/value row doesn't apply and other columns are not present for brevity)

do you mean to remove the field/value row?

khatchad commented 3 years ago

field/value row doesn't apply and other columns are not present for brevity)

do you mean to remove the field/value row?

Yes.

khatchad commented 3 years ago

And:

other columns are not present for brevity

khatchad commented 3 years ago

Hm. I still don't see any changes for https://github.com/ponder-lab/Imperative-DL-Study-Web-App/issues/75#issuecomment-816794588. I am looking at https://fathomless-inlet-57767.herokuapp.com/ponder/bug_fixes/1.

khatchad commented 3 years ago

Also, I think "Categorizations for Bug Fix 1" can be changed to just "Categorizations" because we know from the top that it is for bug fix 1. Thanks!

khatchad commented 3 years ago

These are the fields that should be present at https://fathomless-inlet-57767.herokuapp.com/ponder/bug_fixes/1:

ID
SHA
Is func fix
Problem category
Category comment
Problem cause
Cause comment
Problem symptom
Symptom comment
Problem fix
Fix comment
Should discuss

mZneit commented 3 years ago

I removed the sha column from the bugfix table because it's already there in the smaller table. I'm not sure what you mean by "other columns not present for brevity."

khatchad commented 3 years ago

I'm speaking of the smaller table.

khatchad commented 3 years ago

The "smaller" table is missing:

Category comment
Problem cause
Cause comment
Problem symptom
Symptom comment
Problem fix
Fix comment
Should discuss

mZneit commented 3 years ago

I committed the changes. Please let me know if it's ok or I need to change anything.

khatchad commented 3 years ago

No, this is incorrect. You had it correct the first time. You were just missing fields. There is no need to redesign the view; we just need to add fields to the existing table.

mZneit commented 3 years ago

Ok I added the missing fields. Please let me know if I still need to add any changes.

khatchad commented 3 years ago

Yes, this is correct now, thanks. However, why do the columns move between bug fixes, e.g., https://fathomless-inlet-57767.herokuapp.com/ponder/bug_fixes/1, https://fathomless-inlet-57767.herokuapp.com/ponder/bug_fixes/2. In the former, the field values seem very far away from the field names, while in the latter they are closer. Can they be static between bug fixes, ideally as close as possible to the field names?

mZneit commented 3 years ago

I changed the column size for the table. I think it's better now.

khatchad commented 3 years ago

It's better. Thanks.

ponder-lab / Imperative-DL-Study-Web-App