search

ponder-lab / Optimize-Java-8-Streams-Refactoring

Refactorings for optimizing Java 8 stream client code for greater parallelism and efficiency.
http://cuny.is/streams
Eclipse Public License 1.0
8 stars 7 forks source link

new pull request for #47 #85

Closed yiming-tang-cs closed 7 years ago

yiming-tang-cs commented 7 years ago

Fix for #47.

yiming-tang-cs commented 7 years ago

WOW! I have checked out and used cherry pick. I thought there should be no failure!

khatchad commented 7 years ago

77 is a pull request not an issue, no?

khatchad commented 7 years ago 
ConvertStreamToParallelRefactoringTest.testMotivatingExample:420->helper:278 expected:<[ORDERED]> but was:<[UNORDERED]>
khatchad commented 7 years ago

The last passing build is https://travis-ci.com/ponder-lab/Java-8-Stream-Refactoring/builds/57159781.

khatchad commented 7 years ago

It built https://github.com/ponder-lab/Java-8-Stream-Refactoring/commit/5304a584472f2810a99c904720250923faf502e8.

khatchad commented 7 years ago

Can you ensure that 5304a584472f2810a99c904720250923faf502e8 is in your pull request? I'm working on speeding up the tests. Sorry about that.

yiming-tang-cs commented 7 years ago

77 is a pull request not an issue, no?

Yes, it is a pull request. Sorry.

yiming-tang-cs commented 7 years ago

Can you ensure that 5304a58 is in your pull request? I'm working on speeding up the tests. Sorry about that.

Yes, I do. But there are some wrong values for parameters in the helper method. I think I may fix them. I will see the result for online checking.

yiming-tang-cs commented 7 years ago

It seems online check and local testing pass!

image

khatchad commented 7 years ago

They are passing only because you changed the tests.