Screenshot should not be part of the plug-in

ponder-lab / Rejuvenate-Logging-Levels

An Eclipse plug-in research prototype for automatically rejuvenating log statement levels using degree of interest

Eclipse Public License 2.0

2 stars 3 forks source link

Screenshot should not be part of the plug-in #267

Closed khatchad closed 4 years ago

khatchad commented 4 years ago

The screenshot on our README.md file is part of the UI plug-in. This is only for our Git repo. It doesn't need to be shipped to users of the plug-in. It should not be stored in any of the plug-ins.

Current location: edu.cuny.hunter.log.ui/icons/screenshot.png

yiming-tang-cs commented 4 years ago

Done: 210d00b708c5ce40094becf76ff7a830f51ff531

khatchad commented 4 years ago

A release needs to be made before this can be closed. Also, just modifying README.md is not sufficient to fix this problem. The image is still packaged in the jar file for the UI plug-in. To verify this, make a release and unpack the jar file to see it.

yiming-tang-cs commented 4 years ago

Fixed by version 1.9.0 https://github.com/ponder-lab/Logging-Level-Evolution-Plugin/releases/tag/v1.9.0