search

pondersource / oc-sciencemesh

Sciencemesh app for Own Cloud
MIT License
0 stars 1 forks source link

Marie not showing up in search results #4

Closed michielbdejong closed 2 years ago

michielbdejong commented 2 years ago

I'm able to run through the whole invite exchange and see Marie as a ScienceMesh contact of Einstein's on oc1.docker

But then when I try to share something with Marie, I see 'Federated' search results for roughly any string that contains an '@', but no sign that the search box knows about Marie.

michielbdejong commented 2 years ago

Have to dig into the owncloud sharee search code to see if it's actually referring this to the share provider or just dealing with it heuristically.

michielbdejong commented 2 years ago

Something like https://github.com/sciencemesh/nc-sciencemesh/blob/main/lib/Plugins/ScienceMeshSearchPlugin.php

michielbdejong commented 2 years ago

https://github.com/pondersource/OC-Sciencemesh/tree/main/lib/Plugins exists but I'm not sure whether the OC server code uses it

michielbdejong commented 2 years ago

code passes through here: https://github.com/owncloud/core/blob/1fa4dc0/apps/files_sharing/lib/Controller/ShareesController.php#L586

michielbdejong commented 2 years ago

Let's add an if-statement to https://github.com/owncloud/core/blob/1fa4dc0/apps/files_sharing/lib/Controller/ShareesController.php#L166 and make that a PR to owncloud core

michielbdejong commented 2 years ago

So if sciencemesh app is enabled, call https://github.com/pondersource/OC-Sciencemesh/blob/75d9580/lib/Plugins/ScienceMeshSearchPlugin.php#L29

shokri-navid commented 2 years ago

this problem is resolved on this repo: https://github.com/pondersource/core

shokri-navid commented 2 years ago

Marie in sharee list is marked as SHARE_TYPE_REMOTE but in nextCloud it is characterized by SHARE_TYPE_SCIENCEMESH, should it change?