search

pondersource / remotestorage.js

⬡ JavaScript client library for integrating remoteStorage in apps
https://remotestoragejs.readthedocs.io
MIT License
0 stars 0 forks source link

Running the tests #2

Closed yasharpm closed 1 month ago

yasharpm commented 1 month ago

I am trying to run the test code in order to get started on the tests for the Solid remote.

However I am getting this error message on my attempt to run the tests: Error: node_modules/@inrupt/solid-client/dist/resource/file.d.ts(2,23): error TS2305: Module '"buffer"' has no exported member 'File'.

Here is the output from the test and link github workflow: https://github.com/pondersource/remotestorage.js/actions/runs/9939957430/job/27455595391

I get the same output while trying to run the tests manually using our dev-stock repo.

This is probably due to some incompatibility between the test configuration and the inrupt Solid library.

yasharpm commented 1 month ago

@MahdiBaghbani suggested:

maybe it's because of node versions? You are running against 14, 16 while upstream is running against 18, 20

I'm gonna merge with upstream and try again.

yasharpm commented 1 month ago

Update:

The merge was successful. Running tests still failed due to a typo which I fixed.

Then the tests ran except with one failing about the length of the cleanup array of the RemoteStorage object which was understandable since we have added the new Solid backend to the bunch. So I changed it from 4 to 5 and all the tests are passing now. :-)

yasharpm commented 1 month ago

Ah the lint check is still failing. Which is no issue anymore. I'll fix it.