Column 'remote' cannot be null

michielbdejong commented 1 year ago

Integrity constraint violation: 1048 Column 'remote' cannot be null","userAgent":"Go-http-client/1.1","version":"26.0.0.2","exception":{"Exception":"Doctrine\\DBAL\\Exception\\NotNullConstraintViolationException","Message":"An exception occurred while executing a query: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'remote' cannot be null"

michielbdejong commented 1 year ago

2023-01-30 14:17:50.397 INF ../reva/pkg/ocm/share/manager/nextcloud/nextcloud.go:195 > am.do https://cloud.pondersource.org/index.php/apps/sciencemesh/~einstein/api/ocm/addReceivedShare {"share":{"id":{"opaqueId":"will-be-filled-in-by-the-backend"}, "resourceId":{"storageId":"remote", "opaqueId":"/test-sciencemesh/"}, "name":"/test-sciencemesh/", "permissions":{"permissions":{"getPath":true, "getQuota":true, "initiateFileDownload":true, "listGrants":true, "listContainer":true, "listFileVersions":true, "listRecycle":true, "stat":true}}, "grantee":{"type":"GRANTEE_TYPE_USER", "userId":{"idp":"https://mesh.pondersource.org/", "opaqueId":"einstein"}, "opaque":{"map":{"remoteShareId":{"decoder":"plain", "value":"IjE4Ig=="}, "sharedSecret":{"decoder":"plain", "value":"ZH...pZQ=="}}}}, "owner":{"opaqueId":"marqs", "type":"USER_TYPE_PRIMARY"}, "creator":{"opaqueId":"marqs", "type":"USER_TYPE_PRIMARY"}, "ctime":{"seconds":"1675088270", "nanos":397521344}, "mtime":{"seconds":"1675088270", "nanos":397521344}, "shareType":"SHARE_TYPE_REGULAR"}, "state":"SHARE_STATE_PENDING"} pid=738293 pkg=rgrpc traceid=053c19a9bd865893cbd1183fba13996d

"owner":{"opaqueId":"marqs", "type":"USER_TYPE_PRIMARY"}

owner.idp is null.

michielbdejong commented 1 year ago

Both mesh.pondersource.org and mesh.pondersource.com are running revad version 95173ee2c5343 so I would expect https://github.com/michielbdejong/reva/blob/95173ee2c534388a58152bc3f6c4c62c1d06f314/internal/http/services/ocmd/shares.go#L194 to catch it if the incoming details of the share don't specify an owner idp

michielbdejong commented 1 year ago

Logs from sending reva:

OCM Send! https://mesh.pondersource.org/ocm/shares
{"meshProvider":"https://cs3mesh-iop.apps.dcw1.paas.psnc.pl/",
"name":"/test-sciencemesh/",
"owner":"marqs@",
"protocol":{"name":"webdav","options":{"permissions":"0","remote":"","sharedSecret":"duKFLHRHie"}},"providerId":"\"18\"","shareWith":"einstein"}

So the owner string has 2 parts, but the second part is the empty string :)

pondersource / sciencemesh-php

Column 'remote' cannot be null #138