search

pondersource / sciencemesh-php

Connect your Nextcloud server to Sciencemesh
MIT License
0 stars 1 forks source link

Use inheritance for ScienceMeshShareProvider.php #184

Closed michielbdejong closed 1 year ago

michielbdejong commented 1 year ago

I get the feeling https://github.com/pondersource/nc-sciencemesh/blob/main/lib/ShareProvider/ScienceMeshShareProvider.php contains copy-pasted code from https://github.com/nextcloud/server/blob/master/apps/federatedfilesharing/lib/FederatedShareProvider.php so that should be cleaned up first, we should use inheritance for functions like getChildren etc

michielbdejong commented 1 year ago

We should fix this for NC in the main branch and then in #186 port the fix to the oc-10-take-2 branch.