search

pondersource / sciencemesh-php

Connect your Nextcloud server to Sciencemesh
MIT License
0 stars 1 forks source link

Decide how to distinguish ScienceMesh-based from regular search results in OC-10 #187

Closed michielbdejong closed 1 year ago

michielbdejong commented 1 year ago

In NC we distinguish ScienceMesh-based from regular search results by share type. the share type in the sharee search result object is set to IShare::TYPE_SCIENCEMESH to indicate that the selected share recipient (the "sharee") is a ScienceMesh contact. But in our OC-10 code we use SHARE_TYPE_REMOTE for both regular and ScienceMesh-based sharee search result objects, see https://github.com/pondersource/nc-sciencemesh/blob/oc-10-take-2/lib/Plugins/ScienceMeshSearchPlugin.php#L45

We could try if we can make it work with a custom share type in the sharee search result object, while still using SHARE_TYPE_REMOTE in the database. This might work, since we control both the ShareeSearchPlugin and the ShareProviderFactory.

michielbdejong commented 1 year ago

I think our best option is to try that out and if it doesn't work, we'll think of a plan B. We should add good warnings in the code, explaining that this custom share type only exists to distinguish sharees and when the share actually gets created, it's mapped onto SHARE_TYPE_REMOTE.