ponewheel / android-ponewheel

pOneWheel Android app
MIT License
71 stars 25 forks source link

batteryTemp not right #100

Closed biell closed 4 years ago

biell commented 4 years ago

BatteryTemp only returns on start for me, and always returns the array [25,30] for me. Does it every return anything else for you? Also, I think the 0'th element of the array is what you are supposed to use, not the 1st element. The official OW app says my battery is 25°C, not 30°C. So this part may be a tiny app bug in OWDevice.java

I am wondering if maybe I broke my sensor when installing my Two-X, because I am charging it now, and still it reports 25°C (77°F). I have never known a battery not to warm up at least a little when charging. If someone else ever gets something other than [25,30] from OnewheelCharacteristicBatteryTemp, I would be interested.

I care because I wanted to lay down the framework for updating the results of battery remaining based on the temperature. I can use the controller temperature, which seems to be working, to estimate what the battery would be seeing. But, it seems like I would want to get it from the horses mouth, if I can.

biell commented 4 years ago

After it finally warmed up and the official app lists the temp at 30°C, and now it returns [30,30]. So, the 0'th element of the array is the correct number. I looked through the forums and people almost always list battery temperatures in 5°C increments. So, I think the BMS only reports temperatures in those increments. What I haven't found yet is if the BatteryTemp is ever updated after start. It is a bad time of year to be looking into this, as the temperature is ranging around room temperature.

biell commented 4 years ago

After a 12 mile ride, both numbers were 35°C, so there might be two censors. The official app uses the first one, so I think so should we.

biell commented 4 years ago

Fixed in pull request #101, commit 85f7bfd2b88233fe40210818417df7b3edeacf43

biell commented 4 years ago

merged into master