search

ponewheel / android-ponewheel

pOneWheel Android app
MIT License
72 stars 25 forks source link

Battery v4 #106

Closed biell closed 4 years ago

biell commented 4 years ago

Fixes #105, updates #76 .

This moves statusMode out of sharedPreferences, cleans up the loopers/creates a periodic bluetooth query, and cleans up notifications. Remaining % is now a progress bar. I have vibration working, and each notification is its own entity, so you can use Android notification settings to change the sound or other settings for a specific notification. For example, I opened the Android notification manager settings and set the 50% notification to use the Onewheel App's turnaround warning sound.

With this, I think a basic level of capability to guess battery remaining is ready for end-user testing. My hope is that from here, we just need to tweak the parameters inside Battery.java and maybe add a sharedPreference or two to adjust for board-to-board differences. We can't know that until we get feedback from multiple boards.

Thanks for reviewing this pull request, let me know if we need to make any changes.

kwatkins commented 4 years ago

Sweet! I'll go ahead and merge this as well as give it a few runs... then get it up on the app store asap.