search

ponewheel / android-ponewheel

pOneWheel Android app
MIT License
71 stars 25 forks source link

[Feature Request] Dropbox integration #14

Closed wmaciel closed 6 years ago

wmaciel commented 6 years ago

It would be very handy if the app could automagically upload your newest log files to dropbox or some other cloud storage service.

As it stands now, one needs a third party app to find the log files and share them somewhere else.

wmaciel commented 6 years ago

I plan on work on this on my following spare time.

ebabel commented 6 years ago

@wmaciel This doesn't look too hard: https://www.dropbox.com/developers-v1/core/start/android I was thinking about going DB instead of file, but conversion shouldn't be too hard.

Are you uploading the file for adding to a video? I'd like to see that in action if you have some videos to share :)

wmaciel commented 6 years ago

Yes, I have a project where I am trying to create a stats overlay over my go pro footage.

I am still having some trouble with flickering on the videos, that is why I haven't published any.

Will soon.

i like the DB idea. Is it faster than file writing? A problem with file writing is the IO blocking and the high polling frequency make irregular intervals. Maybe DB solves that?

ebabel commented 6 years ago

@wmaciel had a thought, it might be easier for you to add a 'share' intent for the file instead of integrating with dropbox. Might be easier for users who don't have dropbox as well since its also a 3rd party

I think its up to you, just trying to be helpful

wmaciel commented 6 years ago

@ebabel Why not both?

My android dev knowledge is very limited, so I'll study on how to get those done.

ebabel commented 6 years ago

both is fine too if you have the time :) adding the 'share' intent is like 5 minutes of work, dropbox integration is probably at least a few hours.

DB is faster, but regardless of that we should be doing both async instead of blocking the UI

ebabel commented 6 years ago

I was thinking more about what you said with the file writing being slow, its because we're closing the file and flushing the buffer on every write. Although safer from loss prevention it is very bad for performance. The database would not have this issue.

ebabel commented 6 years ago

Sorry for the tangent but if you don't mind sending, I'd still like to see the video even if there is flickering :)

kwatkins commented 6 years ago

Love the action_send/sharing intent, opens up the data to any app that read it with just a few lines of code. It's mainly used for simple text, but even for sharing the OW stats files it works good enough.

Fully agree on moving the OW stats from file to a DB content provider, would clean up the technical debt hackery I put in that you all are having to work around (sorry!). It might make it slightly tricky to use the sharing intent (since it'll be pulled from the provider) but still easily doable.

And definitely, share the video @wmaciel ! - I'm also wondering how easy it would be to sync/overlay with video taken from the mobile device, or syncing with video uploaded to youtube.

ebabel commented 6 years ago

Don't be sorry Kevin, gotta start somewhere and I'm glad you did!

ebabel commented 6 years ago

@wmaciel we can close this, right?

wmaciel commented 6 years ago

i think so. we got a way to share the file from within the app now. I think adding auto sync with dropbox or drive could come after we have the logs in a db, otherwise we'll have to redo a lot of work.