search

ponewheel / android-ponewheel

pOneWheel Android app
MIT License
71 stars 25 forks source link

Log file sharing #20

Closed wmaciel closed 6 years ago

wmaciel commented 6 years ago

Adds tool bar to the map activity where you can choose to send your log file to other apps.

wmaciel commented 6 years ago

I took me an awful amount of time to get this working. Let me know if I am breaking any best practices guideline. I am still new at app development

wmaciel commented 6 years ago

It looks like it is complaining about the isClosed attribut of OWDevice. I wonder why this hasn't failed before, because it has nothing to do with my change, I think. I'll update the pull request to change the variable type to boolean instead of Boolean. This might solve it.

wmaciel commented 6 years ago

Turns out I can't change ObservableField to ObservableField so I looked further into the problem.

According to this stackoverflow thread the appropriate way to deal with this warning is to mute it.

While I wait for you guys's feedback on this, I'll look for other ways fix it.

kwatkins commented 6 years ago

Yeah, data binding can be a pain, I'll grab and test this.

wmaciel commented 6 years ago

@kwatkins , I think my latest commit passed the checks, but if you look into the CI output, there still is a warning.

I tried looking where it is coming from but no luck. Can you spot it?

kwatkins commented 6 years ago

Yeah, I see it but not worried about it, one of those nag warnings that you hope will fix itself at some point :-) - the bool OW checks seem to work fine. I ran the build with your change and it looks good! About to take a quick ride and test the changes w/ master.

kwatkins commented 6 years ago

This looks good to me. Also @ebabel the cleanup you did seemed to do us a lot of good, the grc exception is no longer being thrown and BLE connections at least seem to be more stable, not sure why, but it does.

I did a bit of road warrior testing and all seems to be good. OH I did hit an unSafe(pothole) & nosedive, spilling a box of chicken mcnuggets and spicy pumpkin latte over the road (don't judge :P)

@ebabel passing to you to test/close!

ebabel commented 6 years ago

Well done @wmaciel. I've never seen a ShareActionProvider before. Looks like more work than what I would have done: https://stackoverflow.com/a/9975439/247325 but probably better in the long run!

ebabel commented 6 years ago

@kwatkins sorry about your nuggets :( hope you didn't get hurt!