search

ponewheel / android-ponewheel

pOneWheel Android app
MIT License
71 stars 25 forks source link

Ble notify fix #43

Closed kwatkins closed 6 years ago

ebabel commented 6 years ago

Maybe instead of enabled it would be more clear as isNotiftyCharacteristic? Also, I don't think ui_enabled is being used.

kwatkins commented 6 years ago

yeah - it would, and removing the ui_enabled, will do a bit more cleanup/readability here soon. this should get it working for now. let's also talk about when you think it'll be ready to push to the app store - let me know when you think it's good and i'll do it, we still need a smooth way to continuous/way for you to be able to push it as well.

-- Kevin

On Sun, Dec 17, 2017 at 11:14 PM, Erik Babel notifications@github.com wrote:

Maybe instead of enabled it would be more clear as isNotiftyCharacteristic? Also, I don't think ui_enabled is being used.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ponewheel/android-ponewheel/pull/43#issuecomment-352343790, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0LrUU9yQSs7lB9O3khEJni9nAxxOWIks5tBhDYgaJpZM4RE_FW .