Debug setting does nothing

ponewheel / android-ponewheel

pOneWheel Android app

MIT License

71 stars 25 forks source link

Debug setting does nothing #82

Open audkar opened 6 years ago

audkar commented 6 years ago

When I toggle ON this Debug option setting:

only this empty layout appears in main screen:

No code is associated with this view
Settings description tells that it should enable DebugDrawer. But build.gradle has dependency which removes DebugDrawer from release build. https://github.com/ponewheel/android-ponewheel/blob/02d22fcb916fe00049a611f53f9c7f22e85ebb9b/app/build.gradle#L74

Can you describe how this setting should behave? Maybe I could fix it.

kwatkins commented 6 years ago

This can be removed, but what it was - and the idea behind it - is to show detailed information we should be showing to users, connection states, errors connecting the board, other things that can help diagnosis shit that can go wrong.

To do this right, we need a way for us/devs to get a dashboard into the usage logs, and a way for users to send error logs that we can tie to bugs and issues. Short of putting firebase and having logs show up there, are there tools/best practices for this for open source projects? If not, we can add firebase, I'll just need to see how to give access to it in the Google Play console for devs.

kwatkins commented 6 years ago

to follow up on this, i feel a bit bad the time between releases on google play - we need a workflow going, where we tag a dev release, gets pushed to google play, we test it internally, looks good, pop it to beta - users love it, we see the logs and that looks good - push to production...

https://github.com/ponewheel/android-ponewheel/issues/17

audkar commented 6 years ago

This can be removed What do you think if full DebugDrawer would be included in release build and this setting toggle could turn on DebugDrawer in release build? (same behavior as written in setting description)?

About continuous delivery pipeline I will answer in dedicated issue :)