ponewheel / android-ponewheel

pOneWheel Android app
MIT License
71 stars 25 forks source link

Battery mods #92

Closed biell closed 4 years ago

biell commented 4 years ago

Please accept this pull request to update ponewheel for user with battery modifications. I have tested against my Two-X, but it is possible a VNR modification might benefit from this, and I would be willing to make enhancements to support VNR if proposed.

This request should resolve Issue #76.

This change adds a new setting preference to allow you to choose from the following methods to report battery remaining:

Please understand that I am not a Java programmer, this literally doubles the total number of lines of Java I have written in my entire life and I have also never worked on an Android app before either. So, please feel free to either merge and fix my code or let me know what needs to be fixed.

I wanted to start with a newer branch, but there was a missing crashlytics configuration file and I wasn't sure what to do about that. If you would prefer I update that branch, we can have a conversation about how to get crashlytics working. This is a pretty simple change, so it won't take long to apply by hand to a newer, non-master branch.

Thank you.

kwatkins commented 4 years ago

Solid! I'll put it through some testing 👍