Don't let command run forever if not intentional

pongasoft / glu

Deployment Automation Platform

Apache License 2.0

521 stars 99 forks source link

Don't let command run forever if not intentional #292

Open ypujante opened 9 years ago

ypujante commented 9 years ago

Right now if an agent is set to execute a never ending command (like top or tail -f xxx), then the command never ends even if the user is no longer "watching". The console should have a default timeout (optional) to abort a command that nobody is watching unless it was marked as "ok to run forever".

sodul commented 9 years ago

Ideally we should be able to set this per fabric, or even better allow an agent's variables to set the timeout:

per console setting (configured in the console's regular settings file)
per fabric setting (configured in the console admin UI)
per agent setting (configured in the agent's property file or env variables)

Thanks!

ypujante commented 9 years ago

The "per agent" setting is a lot harder to implement. If the console needs to detect that "nobody" is watching for some timeout, the issue is that it does not have access to the agent defined timeout. Unless you were thinking about a different implementation of course.