pongasoft / jamba

A lightweight VST2/3 framework
https://jamba.dev/
Apache License 2.0
121 stars 3 forks source link

Web generator does not work #7

Closed ghost closed 4 years ago

ghost commented 4 years ago

Hello

No generated file. Tested with Firefox and Edge (Windows 10 x64)

With Firefox:

### Jamba Plugin Generator Output ###
[OK] Ready.
Wating for user input...
Loading Jamba Blank Plugin...
Loaded Jamba Blank Plugin version v3.2.2 - 36 files.
Plugin [testplugin-src.zip] generated successfully. Downloading...
Download complete (check you download folder).

With Edge:

### Jamba Plugin Generator Output ###
[OK] Ready.
Wating for user input...
Loading Jamba Blank Plugin...
Loaded Jamba Blank Plugin version v3.2.2 - 36 files.
Could not fetch blank plugin - Object doesn't support property or method 'keys'. Try refreshing the page...

Any idea? Thanks.

ypujante commented 4 years ago

The output shows that you are getting a result with Firefox:

Plugin [testplugin-src.zip] generated successfully. Downloading...
Download complete (check you download folder).

Can you please confirm that you can see the plugin with Firefox?

It seems that it does not work with Edge but I have not tested it with Edge.. I will take a look at it but Firefox seems to be good.

ghost commented 4 years ago

I did check the download folder. No file. There is actually no 'testplugin*' file on my hard drive.

ypujante commented 4 years ago

Ok. I will take a look. I am pretty sure it works with Chrome so you may want to try with Chrome

ghost commented 4 years ago

No hurry. If there's no quick fix I'll try the command line tool.

ypujante commented 4 years ago

Ok. I am just bummed cause that is one of the main point of the website...

ypujante commented 4 years ago

I believe the issue is fixed if you can confirm. I tried with Firefox and Edge from a Win10 machine with no issue now. I also added a Download link in case the download does not happen automatically.

ghost commented 4 years ago

Hi

Nice! I can get the file with Firefox.

But I still get the same error message with Edge : Could not fetch blank plugin - Object doesn't support property or method 'keys'. Try refreshing the page... I did refresh the page and clear the cache and cookies... I'll try again later.

ypujante commented 4 years ago

Glad to hear it is working with Firefox.

I am a bit puzzled with Edge because I cannot reproduce the problem. I am using Edge v44.18362.1.0 which I believe is the most recent version and it just works.

The only time when I use the keys method is with the FormData object which according to the spec is compatible with Edge...

ghost commented 4 years ago

I have an older version (v42.17…) that might be not compatible. I suppose you can close the issue.

Thanks for this project.

ypujante commented 4 years ago

Closing this issue since one issue has been fixed and the other one is most likely due to an older version.