search

ponnamkarthik / FlutterToast

Toast Plugin for Flutter
MIT License
1.43k stars 349 forks source link

Removing VALID_ARCHS from `pod_target_xcconfig` in iOS podspec #505

Closed ericbomgardner closed 2 months ago

ericbomgardner commented 2 months ago

Fixes https://github.com/ponnamkarthik/FlutterToast/issues/463

Background

Prior to https://github.com/ponnamkarthik/FlutterToast/pull/405, this line matched the flutter plugin template

`s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES', 'EXCLUDED_ARCHS[sdk=iphonesimulator*]' => 'i386' }`

In #405, arm64 was added to EXCLUDED_ARCHS[sdk=iphonesimulator*] to work around dependencies missing arm64 slices for simulator, but that change is no longer necessary: https://github.com/CocoaPods/CocoaPods/issues/10104#issuecomment-704916617.

In #425, the line was changed to add VALID_ARCHS, which is a deprecated build setting (source).

Most other common flutter packages don't have VALID_ARCHS set in their podspec.

What changes in this PR

VALID_ARCHS is removed -- it's no longer necessary, and was breaking release builds (#463) for some users