search

ponnhide / patchworklib

Patchwork for matplotlib: A subplot manager for intuitive layouts in matplotlib, seaborn, and plotnine.
GNU General Public License v3.0
365 stars 24 forks source link

StrictVersion Fails for matplotlib 3.9.1.post1 #61

Open marcus1487 opened 1 month ago

marcus1487 commented 1 month ago

There is a check in the code that the version of matplotlib is great than 3.7 for a particular feature here in the code. This is currently completed with a StrictVersion check. This check fails with the most recent matplotlib release yesterday (3.9.1.post1). Would it be acceptable to update to from packaging.version import Version instead? Happy to submit a MR is so.

ponnhide commented 1 month ago

Thank you for pointing it out. Yes, it would be acceptable to update the version check to use Version from packaging.version instead of StrictVersion. Please submit MR and I'll review it promptly.