Closed mbabker closed 1 year ago
Refactored executeCommand() method The method executeCommand() has been improved for better usage by utilizing the Process::fromShellCommandline() constructor.
Added timeout parameter to fromShellCommandline() A new parameter $timeout has been introduced to the fromShellCommandline() for better control and flexibility.
Thanks Michael, good catch in thisn PR.
p.s: thank for your work on Pagerfanta :)
The
Symfony\Component\Process\Process
class allows setting a null value for the timeout, indicating the process does not have a timeout. The generator class only configures the timeout when it is a non-null value, making it impossible to configure the generator to run without a timeout (i.e. in a command line context as a system job where a long-running process is intended).This change allows configuring the process to have no timeout by always passing through the timeout value from the generator.
This will have no B/C impact as the generator's constructor has an explicit
$this->setTimeout()
call with a default timeout.