pontem-network / dove

🛠️ Diem/Pontem Move package manager
MIT License
35 stars 13 forks source link

Dove test broken on 1.6 when Diem specific code is referenced #210

Open villesundell opened 2 years ago

villesundell commented 2 years ago

Hello, fellow Move soldiers! We continue marching on, despite the negative news lately. Glad to see 1.6 being released nevertheless :tada:

The previous issue with dove test that was fixed in 1.5.6 (#180) reincarnated in 1.6.0-86817ac.

The test problem being:

┌── test_wrap ──────
│ ITE: An unknown error was reported. Location: 
│ VMError (if there is one): VMError {
│     major_status: UNEXPECTED_VERIFIER_ERROR,
│     sub_status: None,
│     message: Some(
│         "Unexpected verifier/deserialization error! This likely means there is code stored on chain that is unverifiable!\nError: VMError { major_status: MISSING_DEPENDENCY, sub_status: None, message: None, location: Module(ModuleId { address: 0000000000000000000000000000000000000000000000000000000000000001, name: Identifier(\"DiemAccount\") }), indices: [(FunctionHandle, 0)], offsets: [] }",
│     ),
│     location: Module(
│         ModuleId {
│             address: 0000000000000000000000000000000000000000000000000000000000000001,
│             name: Identifier(
│                 "DiemAccount",
│             ),
│         },
│     ),
│     indices: [
│         (
│             FunctionHandle,
│             0,
│         ),
│     ],
│     offsets: [],
│ }
└──────────────────
mkurnikov commented 2 years ago

I don't think this problem is related to named addresses. 1.6.0 right now doesn't support Diem-specific native functions, like ones found in DiemAccount, I assume you're trying to use DiemAccount::create_signer().

As a workaround, you can try Pontem-specific one from here https://github.com/pontem-network/pont-stdlib/blob/master/sources/PontAccount.move#L440 if that fits your case.

I'll get back to you later regarding support for DiemAccount::create_signer() and others.