search

pontem-network / dove

🛠️ Diem/Pontem Move package manager
MIT License
35 stars 15 forks source link

Dove build not generating binaries upon warnings on 1.6.1 #224

Open villesundell opened 2 years ago

villesundell commented 2 years ago

Hello! It seems that binaries are not produced if warnings are encountered (1.6.1-5ac671a).

Consider the following file, let's call it Invalid.move:

/** invalid documentation comment **/

Running dove build will report:

warning[W01004]: invalid documentation comment
  ┌─ ./sources/Invalid.move:1:1
  │
1 │ /** invalid documentation comment **/
  │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Documentation comment cannot be matched to a language item

While most of the warnings are worth fixing, some warnings don't need fixing: for example generics in script functions, which currently report:

warning[W04022]: script function cannot be invoked with this signature (NOTE: this may become an error in the future)

(Ending up not generating binaries.)

The compilation process itself is not aborted, you can see warnings from multiple files. Final binaries are not generated, though.