pontem-network / pontem

🚀 Pontem Parachain node with Move VM onboard.
https://pontem.network
Apache License 2.0
77 stars 43 forks source link

Unboilerplatify code for defining currencies #142

Closed AnthonyMikh closed 2 years ago

AnthonyMikh commented 2 years ago

This changes code to use a macro which enables easily adding new variants of currencies over time and excludes the possibility of mismatching variants in impls. Also new macro statically ensures that byte string identifiers ascipted to variants conform their respective names.

Closes #137

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1508869196


Changes Missing Coverage Covered Lines Changed/Added Lines %
primitives/src/currency.rs 13 34 38.24%
<!-- Total: 13 34 38.24% -->
Files with Coverage Reduction New Missed Lines %
primitives/src/currency.rs 2 21.97%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 1481469308: -4.9%
Covered Lines: 111
Relevant Lines: 209

💛 - Coveralls
boozook commented 2 years ago

Hmmm 🤔 I see tests for this in the pr nearby.