search

ponty / PyVirtualDisplay

Python wrapper for Xvfb, Xephyr and Xvnc
BSD 2-Clause "Simplified" License
697 stars 78 forks source link

upgrade easyprocess to 0.3.0 when pyvirtualdisplay is 0.2.5 #47

Closed Mrfranken closed 2 years ago

Mrfranken commented 4 years ago

hi, really glad to create this pull request. My company is using this lib for selenium headless test for thousands of cases. It really helped us.

Recently my test engineer reported to me that part of cases were failed with pyvirtualdisplay newest version 0.2.5 need easyprocess 0.3.0. But if the easyprocess old version has been already there, upgrading pyvirtualdisplay will not automatically upgrade easyprocess. So I think this maybe need fixed.

Finally, thx for your work and contribution again, it's greate.

surfaceowl commented 4 years ago

+1 for this PR

recently was getting selenium test failures in CircleCI when pyvirtualdisplay upgraded to versions greater than 0.2.1... adding EasyProcess==0.3.0 to requirements.txt fixed breaking tests for me

ponty commented 4 years ago

I could not reproduce this: "pyvirtualdisplay newest version 0.2.5 need easyprocess 0.3.0." I succesfully tested pyvirtualdisplay 0.2.5 with EasyProcess versions back to 0.2.0 (year 2015).
If this happens then please provide more details:

I agree with this: "no need to upgrade easyprocess to newest if it has been installed when user tried to upgrade virtualdisplay above 0.2.5"

I agree with this: "But if your env has install easyprocess >= 0.3.0, only version aboves or equals 0.2.5 for virtualdisplay can work well nowadays." This can't be handled with this PR.