ponylang / crypto

Library of common cryptographic algorithms and functions for Pony
https://ponylang.io
BSD 2-Clause "Simplified" License
11 stars 8 forks source link

Free the underlying digest context on OpenSSL 0.9.0 #55

Closed ergl closed 3 years ago

ergl commented 3 years ago

The code under OpenSSL 0.9.0 was using EVP_MD_CTX_cleanup, which doesn't free the underlying context. This means that the memory allocated with EVP_MD_CTX_create would never be freed, leading to a potential memory leak.

Fixes #54

ponylang-main commented 3 years ago

Hi @ergl,

The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 55.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.