search

ponylang / crypto

Library of common cryptographic algorithms and functions for Pony
https://ponylang.io
BSD 2-Clause "Simplified" License
11 stars 8 forks source link

Support for using ponyup on Windows #66

Closed chalcolith closed 2 years ago

chalcolith commented 2 years ago

Ponyup on Windows creates batch files in its bin directory to select the current version of its tools. This PR changes "ponyc.exe" and "corral.exe" in make.ps1 to ponyc and corral, which will correctly call ponyup's batch files.

It also makes build the default command for make.ps1.

SeanTAllen commented 2 years ago

Does this and the other changes to libraries have a dependency on using ponyup to install ponyc? Will this work if someone builds and installs ponyc themselves or installs from cloudsmith without ponyup?

chalcolith commented 2 years ago

No, there's no dependency on ponyup. These changes just mean that if you happen to be using ponyup then the make.ps1 scripts will work as before. Using your own ponyc build or a cloudsmith build is unaffected.

SeanTAllen commented 2 years ago

Awesome, that wasnt clear to me from the description.

ponylang-main commented 2 years ago

Hi @kulibali,

The changelog - added label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 66.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.