search

ponylang / pony-stable

:horse: A simple dependency manager for the Pony language.
BSD 2-Clause "Simplified" License
134 stars 18 forks source link

Update usage of Env.exitcode to be compatible with ponyc 0.22.x #56

Closed jemc closed 6 years ago

jemc commented 6 years ago

After merging https://github.com/ponylang/ponyc/pull/2617 to ponyc, pony-stable needs this update to be compatible with latest ponyc master.

jemc commented 6 years ago

I notice that this breaks the CI build - what do we want to do about that? Wait until the release of next ponyc to merge this?

SeanTAllen commented 6 years ago

I think so

On Mon, Apr 9, 2018, 5:40 PM Joe Eli McIlvain notifications@github.com wrote:

I notice that this breaks the CI build - what do we want to do about that? Wait until the release of next ponyc to merge this?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ponylang/pony-stable/pull/56#issuecomment-379902671, or mute the thread https://github.com/notifications/unsubscribe-auth/AAL0PP-8MMA7NJ6gq7wx1tRk6lgA0BQzks5tm9U-gaJpZM4TK72k .

SeanTAllen commented 6 years ago

@jemc can you rebase this against master AND switch circle-ci to using "latest" for ci purposes for now? once that passes and 0.22.0 comes out we can update this again to be back on "ponyc-release", watch ci pass and merge to master.

SeanTAllen commented 6 years ago

Actually @jemc, if you rebase this against master now that 0.22.1 is out, we should be good.

SeanTAllen commented 6 years ago

@jemc realized i can rebase this against master. did. running tests.

SeanTAllen commented 6 years ago

Passed!