Builds that contain cyclic dependencies cause an infinite loop

pzel commented 5 years ago

As demonstrated in this demo app, running stable env ponyc in a project that contains cyclic dependencies creates a process that never finishes, consuming more and more memory until it's killed.

Bug report

Current behavior

Cyclic dependencies cause stable env ponyc to fall into an infinite loop.

Expected behavior

Cyclic dependencies get compiled, as happens when using 'plain' ponyc.

Software versions where bug appears:

OS: Linux tmr.local 4.19.20_1 #1 SMP PREEMPT Thu Feb 7 06:55:19 UTC 2019 x86_64 GNU/Linux
Ponyc: 0.25.0-232a0abe [release] compiled with: llvm 3.9.1 -- cc (GCC) 8.2.0 Defaults: pic=true ssl=openssl_0.9.0
Stable: 0.1.3-353733f [release]

SeanTAllen commented 5 years ago

@pzel are you interested in working on a fix for this?

pzel commented 5 years ago

Yes, I can take a stab.

ponylang / pony-stable