ponylang / pony-tutorial

:horse: Tutorial for the Pony programming language
http://tutorial.ponylang.io
BSD 2-Clause "Simplified" License
308 stars 111 forks source link

Move "Match Expressions" and "As Operator" (in that order) into the "Expressions" section, between "Control Structures" and "Methods" #539

Closed shaedrich closed 6 months ago

shaedrich commented 7 months ago

Fix #536

As discussed in https://github.com/ponylang/pony-tutorial/issues/536#issuecomment-2021173572

SeanTAllen commented 7 months ago

This should include redirects from old location to new in netlify.toml

SeanTAllen commented 7 months ago

There's errors on the build side with netlify:

https://app.netlify.com/sites/pony-tutorial/deploys/66032268a3fe2b0009664180

if some of those are internal links than rather than recovering with the redirects (which we want), it would be ideal to fix the internal links as well to go to the correct location rather than following a redirect.

shaedrich commented 7 months ago

Should work now: https://deploy-preview-539--pony-tutorial.netlify.app/expressions/pattern-matching/

SeanTAllen commented 7 months ago

The pattern matching subdirectory should be removed and the overview deleted.

That was the intent. Sorry that wasn't communicated more clearly.

shaedrich commented 7 months ago

Yeah, sorry, I wasn't sure. But no problem, it's fixed now.

SeanTAllen commented 7 months ago

One more small change. Sorry @shaedrich. Thanks for your work on this.

shaedrich commented 7 months ago

No trouble at all. You're welcome, @SeanTAllen.

SeanTAllen commented 6 months ago

Thanks @shaedrich

shaedrich commented 6 months ago

My pleasure, @SeanTAllen