search

ponylang / pony-tutorial

:horse: Tutorial for the Pony programming language
http://tutorial.ponylang.io
BSD 2-Clause "Simplified" License
308 stars 111 forks source link

[4/?] Add ability to run code examples in the playground: Get pony snippets tested with ponyc at CI time #550

Open shaedrich opened 5 months ago

shaedrich commented 5 months ago

Fix #549

See #340

netlify[bot] commented 5 months ago

Deploy Preview for pony-tutorial ready!

Name Link
Latest commit 0eff5c92172526db8642829246c741ef3a99bd5e
Latest deploy log https://app.netlify.com/sites/pony-tutorial/deploys/66592377f44a040008b80541
Deploy Preview https://deploy-preview-550--pony-tutorial.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

shaedrich commented 5 months ago

fyi: The new job fails because currently only one code snippet has expectations set (all of them have to)

SeanTAllen commented 4 months ago

For things that are "ci support scripts" our pattern is to put in .ci-scripts at the top level. If we have an external script like you currently have, it should go there, not in workflows.

SeanTAllen commented 4 months ago

When we add this, we should have a job that is triggered by the new release of a nightly image and new release of a release image to verify we dont have breakage. We have examples of this in a variety of library files. Once this basic on PR change is in, someone ping me and i'll add the "on update" workflows.

shaedrich commented 4 months ago

When we add this, we should have a job that is triggered by the new release of a nightly image and new release of a release image to verify we dont have breakage. We have examples of this in a variety of library files. Once this basic on PR change is in, someone ping me and i'll add the "on update" workflows.

@SeanTAllen As explained above (https://github.com/ponylang/pony-tutorial/pull/550#discussion_r1626454322) to @jemc, the focus of this PR is not my strong suit and it would be great if someone else could tackle this

After all, I guess, [4/?] should start from scratch with a new PR as the implementation will vastly differ from what I tried.

jemc commented 4 months ago

That's okay if you don't want to continue on this particular sub-task - we can try to find someone to pick up this work once your two remaining prior sub-tasks (i.e #545 , #542) are merged.

shaedrich commented 4 months ago

550 is not dependent on #542 so they can be worked on in parallel if wanted.

shaedrich commented 4 months ago

Okay, I guess, I managed to do an implementation with #551, which indeed has to wait for #545 to throw some less errors