Review/Improve Windows backpressure support

ponylang / ponyc

Pony is an open-source, actor-model, capabilities-secure, high performance programming language

http://www.ponylang.io

BSD 2-Clause "Simplified" License

5.68k stars 410 forks source link

Review/Improve Windows backpressure support #1350

Open SeanTAllen opened 7 years ago

SeanTAllen commented 7 years ago

RFC 17 added support for backpressure to the TCPConnection class.

We need a Windows developer to

Review how read and write backpressure were implemented and help refine the implementation (if needed)
Get the TCPThrottle test to pass consistently on Windows.

If you take this on and need assistance, contact @seantallen as he is the domain expert in this area of the Pony stdlib.

damon-kwok commented 4 years ago

@SeanTAllen I tested this feature on windows and I think this issue can be closed. See:


...
---- Passed: net/TCP.writev
---- Passed: net/TCP.expect
---- Passed: net/TCP.expectoverbuffersize
---- Passed: net/TCPMute
---- Passed: net/TCPUnmute
---- Passed: net/TCPProxy
----
---- 270 tests ran.
---- Passed: 270
...

SeanTAllen commented 4 years ago

I implemented Windows backpressure this shouldn't be closed. There has been zero tuning done to it. I know basically nothing about IOCP and did a very "well that works" approach rather than actually looking at this as a IOCP user. Nothing that I raised in the issue has been addressed.